Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly support proto3 optional fields in commonjs+dts .d.ts output #1184

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Correctly support proto3 optional fields in commonjs+dts .d.ts output #1184

merged 3 commits into from
Jan 28, 2022

Commits on Jan 10, 2022

  1. Correctly support proto3 optional fields in commonjs+dts .d.ts output 

    Fixes #1072
    @mattnathan
    mattnathan committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    7259979 View commit details
    Browse the repository at this point in the history

  2. Use has_optional_keyword instead of is_optional

    @mattnathan
    mattnathan committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    75b3145 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Improve the readability of the condition guarding hasXxx .d.ts field … 

    …generation.
    @mattnathan
    mattnathan committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    a0348a2 View commit details
    Browse the repository at this point in the history