-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow null response #1025
Allow null response #1025
Conversation
|
I couldn't build this locally:
|
EasyCLA won't accept my CLA for this. It only seems to apply it to another PR I opened, #1026 |
they said I should close and reopen to get the bot to notice the CLA. doing that now |
this turned out not to solve the problem. there are no |
We're using a custom codec, where null or undefined responses can be represented, and we use that for void methods, similar to how protobuf uses
Empty
.This change allows grpc-web to accept responses that decode to
null
orundefined
.