Skip to content

Commit

Permalink
Revert "Expose MethodDescriptor's public methods (#1160)" (#1199)
Browse files Browse the repository at this point in the history
This reverts commit 97baed4.
  • Loading branch information
sampajano authored Feb 1, 2022
1 parent 454fe5f commit 81ce4c5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 20 deletions.
14 changes: 2 additions & 12 deletions javascript/net/grpc/web/methoddescriptor.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,23 +74,20 @@ const MethodDescriptor = class {

/**
* @override
* @export
*/
getName() {
return this.name;
}

/**
* @override
* @export
*/
getMethodType() {
return this.methodType;
}

/**
* @override
* @export
* @return {function(new: RESPONSE, ...)}
*/
getResponseMessageCtor() {
Expand All @@ -99,25 +96,18 @@ const MethodDescriptor = class {

/**
* @override
* @export
* @return {function(new: REQUEST, ...)}
*/
getRequestMessageCtor() {
return this.requestType;
}

/**
* @override
* @export
*/
/** @override */
getResponseDeserializeFn() {
return this.responseDeserializeFn;
}

/**
* @override
* @export
*/
/** @override */
getRequestSerializeFn() {
return this.requestSerializeFn;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/grpc-web/externs.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,3 @@ module.UnaryResponse.prototype.getResponseMessage = function() {};
module.UnaryResponse.prototype.getMetadata = function() {};
module.UnaryResponse.prototype.getMethodDescriptor = function() {};
module.UnaryResponse.prototype.getStatus = function() {};

module.MethodDescriptor = function() {};
module.MethodDescriptor.getName = function() {};
module.MethodDescriptor.getMethodType = function() {};
module.MethodDescriptor.getResponseMessageCtor = function() {};
module.MethodDescriptor.getRequestMessageCtor = function() {};
module.MethodDescriptor.getResponseDeserializeFn = function() {};
module.MethodDescriptor.getRequestSerializeFn = function() {};

0 comments on commit 81ce4c5

Please sign in to comment.