grpc-js: Re-add client-side max send message size checking #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Jun 24, 2024
murgatroid99
merged commit 97c4cda
into
grpc:@grpc/[email protected]
3 of 5 checks passed
This was referenced Jul 18, 2024
This was referenced Jul 25, 2024
This was referenced Aug 16, 2024
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes for GHSA-7v5v-9h63-cj86 inadvertently removed client-side checking for sending overly large message. That is not a security issue, because that check is just for early notification of the error that the other side would send.