Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Optimizing buffer allocation for server server and bidi streams #2658

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mishimastar
Copy link

@mishimastar mishimastar commented Feb 2, 2024

Logical continuation of PR #2652

Reduced allocated memory while making gRPC grame from 2N+5 bytes to N+5 bytes (where N is length of serialized message)

P.S. Sorry for large diff, this file does not meet the prettier conditions in master branch

@murgatroid99
Copy link
Member

For ease of review, I'd really prefer this PR to just contain the functional changes, and to handle the reformatting separately.

@mishimastar
Copy link
Author

Hope it's more readable at now

@murgatroid99
Copy link
Member

I'm concerned about the Linux test failures. I don't know why this change would cause some calls to be cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants