Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stronger checking for functions in client.js #204

Merged
merged 1 commit into from
Mar 6, 2018
Merged

stronger checking for functions in client.js #204

merged 1 commit into from
Mar 6, 2018

Commits on Mar 6, 2018

  1. stronger checking for functions in client.js 

    checking for functions simply by instanceof would render library usesless in vm or REPL contexts. because if client is created in another V8 context, typeof would still return "function" but instanceof Function would fail and return false for functions and arrow functions. thus it would be impossible to create client before starting a REPL context.
    Mohamad mehdi Kharatizadeh committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    232ff02 View commit details
    Browse the repository at this point in the history