grpc-js: Limit the number of retained channelz trace events #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Linux Tests appear to be failing because of a couple of flakes in the compatibility test with the native library, specifically on the native library side. I don't think that's a problem for grpc-js. |
nicolasnoble
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits the number of trace events that can be retained at any one time per channel/subchannel/server, in an attempt to limit the total memory usage and hopefully fix #1941.
channelz.proto has the following comment on the
num_events_loggedfield of theChannelTracemessage:I am interpreting this as permission to discard old events when the implementation decides it is necessary.