grpc-js: Speculative fix for ECONNRESET errors #1705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of people in googleapis/nodejs-firestore#1023 have reported calls ending with INTERNAL errors triggered by an underlying error that says "read ECONNRESET". Those should be reported as UNAVAILABLE. My guess is that Node is reporting these errors in the form of a
SystemError
with the codeECONNRESET
. If that is the case, we can distinguish those errors and change the code. I also added some logging for the errors from Node to hopefully get a better idea of the error structure if this doesn't work.If that information isn't actually available in a structured way in the error, we might have to fall back to parsing the error message but I really hope we can avoid that because those messages are supposed to be human-readable, not machine-parseable.