grpc-js: server: cull closed sessions from list, check for closed in tryShutdown #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasnoble
reviewed
Jun 9, 2020
| pendingChecks += this.sessions.size; | ||
| this.sessions.forEach((session) => { | ||
| session.close(maybeCallback); | ||
| if (!session.closed) { | ||
| pendingChecks += 1; |
There was a problem hiding this comment.
Took me a second to realize why this was added. I don't like the fact there's a disjoint between adding a new pending action, and incrementing this counter: this feels brittle. But I don't see a way to do this without over engineering it completely:
function addAction(action) {
pendingChecks++;
action(maybeCallback);
}
[...]
addAction(callback => session.close(callback));There was a problem hiding this comment.
I don't know if this is worth changing here but I'm glad you brought it up because there was actually an error. See the new commit.
nicolasnoble
approved these changes
Jun 9, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently written, the
sessionsfield tracks every HTTP/2 session that has ever been established with the server, which can grow without bound. If we remove the ones that are closed, it should be bounded by network connection limits. The check forsession.closedintryShutdownshould avoid potential race conditions, where we get to that line and thecloseevent is pending but has not fired yet.I think this will fix #1458.