grpc-js: Client waitForReady callback fix. Fixes #1352 #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change the commit messages to follow convention of |
badsyntax
commented
Apr 18, 2020
packages/grpc-js/test/test-client.ts
Outdated
| .EchoService as ServiceClientConstructor; | ||
|
|
||
| server = new Server(); | ||
| server.addService(echoService.service, { |
There was a problem hiding this comment.
Does this test rely on a service being added to the server? I don't think client.waitForReady depends on this, see:
There was a problem hiding this comment.
No, waitForReady should not depend on the server having any services. In fact, the whole test file can be simplified significantly by omitting all of the protobuf stuff and directly using grpc.Client.
There was a problem hiding this comment.
I'll simplify the tests.
There was a problem hiding this comment.
I've made that change.
…ixes grpc#1352 In the case where a new watcher is synchronously added to the watcher queue via the watcher callback, this can result in the callback being called multiple times. To support this case, the watcher needs to be move removed from the queue before calling the watcher callback.
badsyntax
force-pushed
the
client-waitforready-fix
branch
from
642a520 to
8b96e36
Compare
badsyntax
force-pushed
the
client-waitforready-fix
branch
from
8b96e36 to
615a3c6
Compare
badsyntax
changed the title
badsyntax
changed the title
No need to add a service to the server to test the client.
badsyntax
force-pushed
the
client-waitforready-fix
branch
from
9d1e8be to
7e381f7
Compare
murgatroid99
approved these changes
Apr 20, 2020
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352