New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Channel#getConnectivityState API and behavior #1186

Merged

murgatroid99 merged 1 commit into grpc:master from murgatroid99:grpc-js_getConnectivityState_fix

Nov 15, 2019

Member

murgatroid99 commented Nov 15, 2019 •

edited

Loading

This is what the spec says that method should do. This part of the functionality got lost when the Channel class was rewritten in #1015.

This is probably what's causing googleapis/nodejs-pubsub#818.


          Fix Channel#getConnectivityState API and behavior

7f62173

murgatroid99 requested a review from nicolasnoble

November 15, 2019 21:09

nicolasnoble approved these changes

View reviewed changes

murgatroid99 merged commit bac812e into grpc:master

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet