Don't allow null load balancing configs

grpc · May 5, 2020 · 7aa9177 · 7aa9177
1 parent 6e202e0
commit 7aa9177
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/packages/grpc-js/src/load-balancer-child-handler.ts b/packages/grpc-js/src/load-balancer-child-handler.ts
@@ -84,12 +84,9 @@ export class ChildLoadBalancerHandler implements LoadBalancer {
    */
   updateAddressList(
     addressList: SubchannelAddress[],
-    lbConfig: LoadBalancingConfig | null,
+    lbConfig: LoadBalancingConfig,
     attributes: { [key: string]: unknown }
   ): void {
-    if (lbConfig === null) {
-      return;
-    }
     let childToUpdate: LoadBalancer;
     if (
       this.currentChild === null ||

diff --git a/packages/grpc-js/src/load-balancer-pick-first.ts b/packages/grpc-js/src/load-balancer-pick-first.ts
@@ -383,7 +383,7 @@ export class PickFirstLoadBalancer implements LoadBalancer {
 
   updateAddressList(
     addressList: SubchannelAddress[],
-    lbConfig: LoadBalancingConfig | null
+    lbConfig: LoadBalancingConfig
   ): void {
     // lbConfig has no useful information for pick first load balancing
     /* To avoid unnecessary churn, we only do something with this address list

diff --git a/packages/grpc-js/src/load-balancer-round-robin.ts b/packages/grpc-js/src/load-balancer-round-robin.ts
@@ -189,7 +189,7 @@ export class RoundRobinLoadBalancer implements LoadBalancer {
 
   updateAddressList(
     addressList: SubchannelAddress[],
-    lbConfig: LoadBalancingConfig | null
+    lbConfig: LoadBalancingConfig
   ): void {
     this.resetSubchannelList();
     trace(

diff --git a/packages/grpc-js/src/load-balancer.ts b/packages/grpc-js/src/load-balancer.ts
@@ -67,7 +67,7 @@ export interface LoadBalancer {
    */
   updateAddressList(
     addressList: SubchannelAddress[],
-    lbConfig: LoadBalancingConfig | null,
+    lbConfig: LoadBalancingConfig,
     attributes: { [key: string]: unknown }
   ): void;
   /**