New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Nack xds response when weighted cluster total weight sums zero #9738

Merged

YifeiZhuang merged 1 commit into grpc:master from YifeiZhuang:back-zero-weight

Dec 7, 2022

Contributor

YifeiZhuang commented Dec 7, 2022

total_weight is deprecated and we should validate on the sum of the cluster weights
envoyproxy/envoy#23170


          Nack xds response when weighter cluster is sum zero

d6813c9

YifeiZhuang requested a review from ejona86

December 7, 2022 18:16

ejona86 approved these changes

View reviewed changes

YifeiZhuang merged commit 7864170 into grpc:master

YifeiZhuang deleted the back-zero-weight branch

December 7, 2022 21:16

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet