core: Disable retry by default for in-process transport's channel #9361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
added
the
TODO:backport
ejona86
reviewed
Jul 11, 2022
| @@ -123,7 +127,7 @@ protected ManagedChannelBuilder<?> delegate() { | |||
| } | |||
|
|
|||
| @Override | |||
| public final InProcessChannelBuilder maxInboundMessageSize(int max) { | |||
| public InProcessChannelBuilder maxInboundMessageSize(int max) { | |||
There was a problem hiding this comment.
This change was to eliminate a warning of the redundancy of a final method in a final class.
|
There was a warning about a final method in a final class being redundant.
On Mon, Jul 11, 2022 at 3:49 PM Eric Anderson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In core/src/main/java/io/grpc/inprocess/InProcessChannelBuilder.java
<#9361 (comment)>:
> @@ -123,7 +127,7 @@ protected ManagedChannelBuilder<?> delegate() {
}
@OverRide
- public final InProcessChannelBuilder maxInboundMessageSize(int max) {
+ public InProcessChannelBuilder maxInboundMessageSize(int max) {
Why this change?
—
Reply to this email directly, view it on GitHub
<#9361 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZQMCXU42LOWKQUTCNDJSNDVTSQI7ANCNFSM53I3IUCQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Thanks,
Larry
|
ejona86
approved these changes
Jul 12, 2022
larry-safran
added
TODO:backport
|
Backport is happening in PR #9368 |
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Jul 19, 2022
temawi
pushed a commit
to temawi/grpc-java
that referenced
this pull request
Jul 22, 2022
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mitigates the problem that the buffer limit is not being respected by in-process transport since there is no wire so the bytes aren't actually serialized. Full fix to follow.
See #8712