Bump protobuf to 3.21.1 #9311
Merged
Bump protobuf to 3.21.1 #9311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build's still broken. |
|
It was a conflict due to Terry's recent Netty upgrade. I had done a push real quick before a meeting hoping Linux would be passing. I know Windows should still be failing due to a build change in Protobuf. |
|
Restarted java 11 build - it was running out of memory. |
|
protocolbuffers/protobuf#10174 I'm not sure how we'll want to react to the build bug. |
This should fix the build, but I don't see any warning about it being deprecated in the logs. Looks like the compat for the old way isn't working. protocolbuffers/protobuf#9596
|
@sergiitk, CI is still running, but it seems it is likely working now. |
sergiitk
approved these changes
Jun 29, 2022
|
Ugh. This is going to be a PITA to backport. |
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Jun 30, 2022
ejona86
added a commit
that referenced
this pull request
Jul 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9264