xds: eds reuse priority names for the same existing locality #9287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Jun 24, 2022
| } | ||
| } | ||
| if ("".equals(foundName)) { | ||
| foundName = String.format("%s[priority%d]", name, priorityNameGenId++); |
There was a problem hiding this comment.
If we only have to update tests in ClusterResolverLoadBalancerTest, let's change "priority" to "child" like we had briefly discussed. There aren't that many occurrences in ClusterResolverLoadBalancerTest to keep around this confusion.
| @@ -342,6 +345,8 @@ void shutdown() { | |||
| private final class EdsClusterState extends ClusterState implements EdsResourceWatcher { | |||
| @Nullable | |||
| private final String edsServiceName; | |||
| private Map<Locality, String> localityPriorityNames = new HashMap<>(); | |||
There was a problem hiding this comment.
Collections.emptyMap() would make it a bit more obvious the reference is modified instead of the map itself.
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.google.com/document/d/13L2YVTGI2OrLpeCAPbgI4qEs0Oz02P7X0DKhk6Y9LMk/edit#
related in go: grpc/grpc-go#5268