-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cross-compiling for ppc64le platform #9284
Conversation
..on the lines of grpc#6441
|
Remove code duplication
Looks like we need to check what distro and stuff is being used in kokoro. :-/
|
Not sure how to fix this for cross compilation:
|
Those incompatible libraries are most likely x86 libraries. The incompatible libraries aren't much of a problem; they will be skipped. The real problem is
-L in LDFLAGS adds a path to be searched when linking (the step you are seeing an error). And LD_LIBRARY_PATH adds a path to be searched when running the binary. |
The host string looks wrong to me. Adding the fix...
|
exe was built successfully. Are we using the wrong objdump?
|
Oh, it is close! Hmmm... That's an explicit check in the check-artifact.sh script. It does seem broken that arm and ppc would have the same string. Line 55 does call objdump without a prefix. |
@ejona86
|
@ejona86 Looks like the Bazel build failed due to a JVM crash. All else LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change in check-artifacts for getting the format should probably be cleaned up in the future, but we can do that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
..on the lines of #6441