build.gradle: Clear Class-Path from shadowJar manifest #9270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated Class-Path is simply wrong and it will actually be attempted to be used at runtime. Fixes grpc#8606
ejona86
force-pushed
the
clear-shadow-classpath
branch
from
a77bc21
to
82c582f
Compare
|
This issue had come up again when working on #9269 as the "thirdparty" sourceSet was being added to Class-Path. |
michaelli321
approved these changes
Jun 13, 2022
YifeiZhuang
approved these changes
Jun 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated Class-Path is simply wrong and it will actually be
attempted to be used at runtime.
Fixes #8606