Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls: fix child lb leak when client channel is shutdown [backport v1.44.x] #8830

Merged
merged 1 commit into from
Jan 14, 2022
Merged

rls: fix child lb leak when client channel is shutdown [backport v1.44.x] #8830

merged 1 commit into from
Jan 14, 2022

Conversation

dapengzhang0
Copy link
Member

@dapengzhang0 dapengzhang0 commented Jan 12, 2022 •
edited
Loading

Backport of #8750

When client channel is shutting down, the RlsLoadBalancer is shutting down. However, the child loadbalancers of RlsLoadBalancer are not shut down. This is causing the issue b/209831670

@dapengzhang0
rls: fix child lb leak when client channel is shutdown (grpc#8750)
f6a6fe1 
When client channel is shutting down, the RlsLoadBalancer is shutting down. However, the child loadbalancers of RlsLoadBalancer are not shut down. This is causing the issue b/209831670
@dapengzhang0 dapengzhang0 changed the title rls: fix child lb leak when client channel is shutdown (#8750) rls: fix child lb leak when client channel is shutdown [backport v1.44.x] Jan 12, 2022
@dapengzhang0 dapengzhang0 requested a review from sergiitk January 12, 2022 23:40
@dapengzhang0 dapengzhang0 added kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary and removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Jan 13, 2022
@dapengzhang0 dapengzhang0 reopened this Jan 13, 2022
@dapengzhang0 dapengzhang0 added kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary and removed kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary labels Jan 13, 2022
@sergiitk sergiitk added kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run and removed kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary labels Jan 14, 2022
@dapengzhang0 dapengzhang0 removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jan 14, 2022
@dapengzhang0 dapengzhang0 reopened this Jan 14, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 14, 2022
@dapengzhang0 dapengzhang0 merged commit f7e6d69 into grpc:v1.44.x Jan 14, 2022
@dapengzhang0 dapengzhang0 deleted the v1.44.x branch January 14, 2022 19:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dapengzhang0 @sergiitk @grpc-kokoro