Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildscripts: always make sure we are using jdk8 for build and test #8800

Merged
merged 1 commit into from
Jan 4, 2022
Merged

buildscripts: always make sure we are using jdk8 for build and test #8800

merged 1 commit into from
Jan 4, 2022

Conversation

sanjaypujare
Copy link
Contributor

@ejona86 as discussed

@sanjaypujare sanjaypujare requested a review from ejona86 January 4, 2022 20:15
ejona86
ejona86 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a follow-up at some point to remove the usage of JAVA_HOME (preferring PATH instead), but the CI is broken at the moment, so this is quite fine for the moment.

@sanjaypujare sanjaypujare merged commit e474e3d into grpc:master Jan 4, 2022
@sanjaypujare sanjaypujare deleted the macos-java-fix branch January 4, 2022 21:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanjaypujare @ejona86