xds: add and parse new bootstrap fields for federation #8608
Conversation
dapengzhang0
force-pushed
the
bootstrap-federation
branch
from
9e088bf to
99fca4f
Compare
| /** | ||
| * A template for the name of the Listener resource to subscribe to for a gRPC server. | ||
| * | ||
| * <p>If starts with "xdstp:", will be interpreted as a new-style name, in which case the |
There was a problem hiding this comment.
if using new style, e.g. xdstp://foo.google.com then it would look up server listener template in the authority map with the key foo.google.com? If so, it basically does nothing.
There was a problem hiding this comment.
I don't really understand. Why it basically does nothing? There are some "gRPC server for "0.0.0.0:8080" examples in the design doc, I'm not 100% familiar with the server side, were there any problem with the examples?
There was a problem hiding this comment.
oh no problem, i was not familiar with the design doc.
I was just imagining the lookup at the server side will be at runtime, currently it looks hardcode in the bootstrap.
| /** | ||
| * A template for the name of the Listener resource to subscribe to for a gRPC server. | ||
| * | ||
| * <p>If starts with "xdstp:", will be interpreted as a new-style name, in which case the |
There was a problem hiding this comment.
oh no problem, i was not familiar with the design doc.
I was just imagining the lookup at the server side will be at runtime, currently it looks hardcode in the bootstrap.
Made changes as per "Bootstrap File Changes" section in go/grpc-xds-federation and implemented bootstrap file parsing logic for the change. How the new parsed data will be used will be implemented in upcoming PRs.