Modify netty-shaded resources to reference shaded class names #8258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Jun 16, 2021
| @Test | ||
| public void nettyResourcesUpdated() throws IOException { | ||
| InputStream inputStream = NettyChannelBuilder.class.getClassLoader() | ||
| .getResourceAsStream("META-INF/native-image/io.netty/transport/reflection-config.json"); |
There was a problem hiding this comment.
We really ought to rename the files as well (the "io.netty" folder), to avoid them colliding with Netty's files. But we can do that as a follow-up.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
|
@dzou, thank you! |
Thanks for the quick review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the shading operation to transform native-image resources so they correctly reference shaded class names.
Fixes #7540.
cc/ @meltsufin