Include native-image.properties in Netty shaded #7657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Dec 9, 2020
| @@ -25,9 +25,6 @@ | |||
| import java.util.ServiceLoader; | |||
|
|
|||
| final class ServiceProviders { | |||
| private ServiceProviders() { | |||
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| Args = --initialize-at-build-time=io.grpc.netty.shaded.io.netty \ |
There was a problem hiding this comment.
We don't want this hard-coded in gRPC. If you really wanted to avoid making the transformer/relocator, then you could extract the file from the Netty jar dependency. But hard-coding it here is a dead-end.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix to #7540. This PR does not have a custom Transformer instead reads the configuration from a file and rewrites
native-image.propertiesinsideMETA-INF