Revert "Revert "stub: Wait for onClose when blocking stub is interrupted"" #6255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted"" This reverts commit 0604e14.
voidzcy
changed the title
ejona86
approved these changes
Oct 7, 2019
|
Thank you for tracking this down! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0604e14.
Previously, the change caused an internal test to hang. But this was caused by Exoblaze (Bazel's
BuildEventServiceModule)'s timeout management. Not 100% sure, but I am suspecting that it's logic in waiting for shutdown on the same thread (which is the same thread as gRPC's transport thread) caused theCancelClientStreamCommandnever had chance to run.The issue was fixed in bazelbuild/bazel@82f5090#diff-a4dcfc83b91b9ec1e362e379e4331377R417. So nothing needs to be done on our side and we can proceed to roll this forward.
Previous broken tests have passed after applying this change to latest Exoblaze.
Resolves #5576.