Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis.yml: Actually trigger coveralls #4709

Merged
merged 1 commit into from
Jul 30, 2018
Merged

travis.yml: Actually trigger coveralls #4709

merged 1 commit into from
Jul 30, 2018

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jul 30, 2018

Previously it was just erroring:
[[: command not found

@ejona86
travis.yml: Actually trigger coveralls
12907ef 
Previously it was just erroring:
[[: command not found
carl-mastrangelo
carl-mastrangelo approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backports?

@ejona86
Copy link
Member Author

ejona86 commented Jul 30, 2018

I could, but we probably don't care? It broke in #3638, so everything back to 1.12 would need the change.

@ejona86 ejona86 merged commit c032aba into grpc:master Jul 30, 2018
@ejona86 ejona86 deleted the actually-coveralls branch July 30, 2018 19:44
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carl-mastrangelo carl-mastrangelo carl-mastrangelo approved these changes

Assignees

@carl-mastrangelo carl-mastrangelo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejona86 @carl-mastrangelo