examples: use the official error_details.proto

[dapengzhang0]

The error_details.proto file in examples/src/main/proto/ was not originated from grpc-java.
It was officially opensourced at https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto

[ericgribkoff]

I think this should use proto-google-common-protos, not grpc-google-common-protos. See #2961 (comment)

[dapengzhang0]

Thanks! Updated.

[ericgribkoff]

LGTM. I filed #3152 to follow-up on the build environment for proto-google-common-protos, which is already a dependency in grpc-protobuf.

[ejona86]

Maven build is pretty broken. See the Travis logs.

[dapengzhang0]

That's interesting, the 1st commit using grpc-google-common-protos worked.

[ejona86]

FYI: this will conflict with #3150

[dapengzhang0]

Is there any particular reason we use v0.1.9 in grpc-protobuf? Can we bump to v0.1.12 globally?

[dapengzhang0]

proto-google-common-protos v0.1.9 pom.xml

<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>3.2.0</version>

proto-google-common-protos v0.1.12 pom.xml

<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>3.3.0</version>

[ejona86]

Let's add maven-enforcer-plugin to the pom.xml to detect problems like this in the future. It's important for our users to do the same:

      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-enforcer-plugin</artifactId>
        <version>1.4.1</version>
        <executions>
          <execution>
            <id>enforce</id>
            <goals>
              <goal>enforce</goal>
            </goals>
            <configuration>
              <rules>
                <requireUpperBoundDeps/>
              </rules>
            </configuration>
          </execution>
        </executions>
      </plugin>

[ejona86]

Actually, I'm just going to do the maven enforcer part in #3158.