build,protobuf: update google_api_protos dependency #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:( Why does it depend on api-common? |
ejona86
approved these changes
May 1, 2017
ejona86
requested changes
May 1, 2017
protobuf/build.gradle
Outdated
| @@ -16,7 +16,6 @@ dependencies { | |||
| libraries.protobuf_util | |||
|
|
|||
| compile (libraries.google_api_protos) { | |||
| exclude group: 'io.grpc' | |||
| // 'com.google.api' transitively depends on 'com.google.auto.value:auto-value:1.1', which | |||
| // breaks our annotations. | |||
| exclude group: 'com.google.api' | |||
There was a problem hiding this comment.
Also specify the artifact name, so that it avoids the wildcard in the pom.
ericgribkoff
force-pushed
the
fix_dependency
branch
from
ccd8893 to
38aa015
Compare
|
I'm not sure why they depend on api-common. It's not clear to me from https://github.com/googleapis/googleapis how the jar is even produced or what it contains, without looking through the jar from maven itself. Should I open an issue on https://github.com/googleapis/googleapis about this dependency? |
|
Yeah, please open an issue about it, and CC me on it. |
ejona86
approved these changes
May 1, 2017
ejona86
added
the
TODO:backport
ejona86
removed
the
TODO:backport
|
Backported to 1.3.x in #3155 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2961.
Thanks to @zhangkun83 who identified a similar issue with instrumentation-java, I've sent googleapis/api-common-java#27 to make their dependency on auto-value compileOnly, which will enable remove the remaining
exclude groupfrom the dependency onlibraries.google_api_protos. AFAIK the presence of this rule doesn't impact #2961.