Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSM] Use xds-enabled server and xds credentials in examples #11706

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Nov 26, 2024

Change -
The CSM Observability examples will now use an xDS enabled server and xds credentials with a fallback on insecure credentials. This allows users to try configuring authn/mtls and authz/rbac using the same example images.

(Existing example uses a non-xds enabled server and insecure credentials.)

@yashykt yashykt requested a review from DNVindhya November 26, 2024 00:47
Copy link
Contributor

@DNVindhya DNVindhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Can you fill in the PR description as well?

@yashykt yashykt merged commit a79982c into grpc:master Nov 26, 2024
15 checks passed
yashykt added a commit to yashykt/grpc-java that referenced this pull request Nov 26, 2024
Copy link
Contributor

@DNVindhya DNVindhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DNVindhya pushed a commit that referenced this pull request Nov 27, 2024
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants