Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Add counter and gauge metrics #11661

Merged
merged 13 commits into from
Nov 26, 2024

Instead of storing MetricRecorder, pass it as is for XdsClient creation

4f01651
Select commit
Loading
Failed to load commit list.
Merged

xds: Add counter and gauge metrics #11661

Instead of storing MetricRecorder, pass it as is for XdsClient creation
4f01651
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 8, 2024 in 0s

91.39% of diff hit (target 80.00%)

View this Pull Request on Codecov

91.39% of diff hit (target 80.00%)

Annotations

Check warning on line 429 in api/src/main/java/io/grpc/NameResolver.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/io/grpc/NameResolver.java#L429 

Added line #L429 was not covered by tests

Check warning on line 40 in xds/src/main/java/io/grpc/xds/InternalSharedXdsClientPoolProvider.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/src/main/java/io/grpc/xds/InternalSharedXdsClientPoolProvider.java#L40 

Added line #L40 was not covered by tests

Check warning on line 45 in xds/src/main/java/io/grpc/xds/InternalSharedXdsClientPoolProvider.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/src/main/java/io/grpc/xds/InternalSharedXdsClientPoolProvider.java#L45 

Added line #L45 was not covered by tests

Check warning on line 139 in xds/src/main/java/io/grpc/xds/XdsClientMetricReporterImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/src/main/java/io/grpc/xds/XdsClientMetricReporterImpl.java#L139 

Added line #L139 was not covered by tests

Check warning on line 394 in xds/src/main/java/io/grpc/xds/client/XdsClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/src/main/java/io/grpc/xds/client/XdsClient.java#L394 

Added line #L394 was not covered by tests

Check warning on line 403 in xds/src/main/java/io/grpc/xds/client/XdsClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/src/main/java/io/grpc/xds/client/XdsClient.java#L403 

Added line #L403 was not covered by tests

Check warning on line 38 in xds/src/main/java/io/grpc/xds/client/XdsClientMetricReporter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/src/main/java/io/grpc/xds/client/XdsClientMetricReporter.java#L38 

Added line #L38 was not covered by tests

Check warning on line 48 in xds/src/main/java/io/grpc/xds/client/XdsClientMetricReporter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/src/main/java/io/grpc/xds/client/XdsClientMetricReporter.java#L48 

Added line #L48 was not covered by tests

Check warning on line 60 in xds/src/main/java/io/grpc/xds/client/XdsClientMetricReporter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/src/main/java/io/grpc/xds/client/XdsClientMetricReporter.java#L60 

Added line #L60 was not covered by tests

Check warning on line 64 in xds/src/main/java/io/grpc/xds/client/XdsClientMetricReporter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

xds/src/main/java/io/grpc/xds/client/XdsClientMetricReporter.java#L64 

Added line #L64 was not covered by tests
View more details on Codecov