-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netty:Fix Netty composite buffer merging to be compatible with Netty 4.1.111 (1.64.x backport) #11303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4.1.111 (grpc#11294) * Use addComponent instead of addFlattenedComponent and do not append to components that are composites.
ejona86
approved these changes
Jun 21, 2024
sergiitk
approved these changes
Jun 21, 2024
renovate bot
referenced
this pull request
in TBD54566975/ftl
Jul 1, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [github.com/aws/aws-sdk-go-v2](https://togithub.com/aws/aws-sdk-go-v2) | `v1.30.0` -> `v1.30.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2/v1.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2/v1.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2/v1.30.0/v1.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2/v1.30.0/v1.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/aws/aws-sdk-go-v2/config](https://togithub.com/aws/aws-sdk-go-v2) | `v1.27.21` -> `v1.27.23` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.21/v1.27.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fconfig/v1.27.21/v1.27.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/aws/aws-sdk-go-v2/credentials](https://togithub.com/aws/aws-sdk-go-v2) | `v1.17.21` -> `v1.17.23` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fcredentials/v1.17.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fcredentials/v1.17.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fcredentials/v1.17.21/v1.17.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fcredentials/v1.17.21/v1.17.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/aws/aws-sdk-go-v2/service/secretsmanager](https://togithub.com/aws/aws-sdk-go-v2) | `v1.31.1` -> `v1.32.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsecretsmanager/v1.32.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsecretsmanager/v1.32.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsecretsmanager/v1.31.1/v1.32.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go-v2%2fservice%2fsecretsmanager/v1.31.1/v1.32.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/aws/smithy-go](https://togithub.com/aws/smithy-go) | `v1.20.2` -> `v1.20.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2fsmithy-go/v1.20.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2fsmithy-go/v1.20.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2fsmithy-go/v1.20.2/v1.20.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2fsmithy-go/v1.20.2/v1.20.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [postcss](https://postcss.org/) ([source](https://togithub.com/postcss/postcss)) | [`8.4.38` -> `8.4.39`](https://renovatebot.com/diffs/npm/postcss/8.4.38/8.4.39) | [![age](https://developer.mend.io/api/mc/badges/age/npm/postcss/8.4.39?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/postcss/8.4.39?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/postcss/8.4.38/8.4.39?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/postcss/8.4.38/8.4.39?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [shalzz/zola-deploy-action](https://togithub.com/shalzz/zola-deploy-action) | `v0.18.0` -> `v0.19.1` | [![age](https://developer.mend.io/api/mc/badges/age/github-tags/shalzz%2fzola-deploy-action/v0.19.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/shalzz%2fzola-deploy-action/v0.19.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/shalzz%2fzola-deploy-action/v0.18.0/v0.19.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/shalzz%2fzola-deploy-action/v0.18.0/v0.19.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | action | minor | | [org.junit:junit-bom](https://junit.org/junit5/) ([source](https://togithub.com/junit-team/junit5)) | `5.10.2` -> `5.10.3` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.junit:junit-bom/5.10.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.junit:junit-bom/5.10.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.junit:junit-bom/5.10.2/5.10.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.junit:junit-bom/5.10.2/5.10.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | import | patch | | [io.grpc:grpc-stub](https://togithub.com/grpc/grpc-java) | `1.64.0` -> `1.65.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.grpc:grpc-stub/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.grpc:grpc-stub/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.grpc:grpc-stub/1.64.0/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.grpc:grpc-stub/1.64.0/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | compile | minor | | [io.grpc:grpc-protobuf](https://togithub.com/grpc/grpc-java) | `1.64.0` -> `1.65.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.grpc:grpc-protobuf/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.grpc:grpc-protobuf/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.grpc:grpc-protobuf/1.64.0/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.grpc:grpc-protobuf/1.64.0/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | compile | minor | | [io.grpc:grpc-netty](https://togithub.com/grpc/grpc-java) | `1.64.0` -> `1.65.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.grpc:grpc-netty/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.grpc:grpc-netty/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.grpc:grpc-netty/1.64.0/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.grpc:grpc-netty/1.64.0/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | compile | minor | --- ### Release Notes <details> <summary>aws/aws-sdk-go-v2 (github.com/aws/aws-sdk-go-v2)</summary> ### [`v1.30.1`](https://togithub.com/aws/aws-sdk-go-v2/compare/v1.30.0...v1.30.1) [Compare Source](https://togithub.com/aws/aws-sdk-go-v2/compare/v1.30.0...v1.30.1) </details> <details> <summary>aws/smithy-go (github.com/aws/smithy-go)</summary> ### [`v1.20.3`](https://togithub.com/aws/smithy-go/compare/v1.20.2...v1.20.3) [Compare Source](https://togithub.com/aws/smithy-go/compare/v1.20.2...v1.20.3) </details> <details> <summary>postcss/postcss (postcss)</summary> ### [`v8.4.39`](https://togithub.com/postcss/postcss/blob/HEAD/CHANGELOG.md#8439) [Compare Source](https://togithub.com/postcss/postcss/compare/8.4.38...8.4.39) - Fixed `CssSyntaxError` types (by [@​romainmenke](https://togithub.com/romainmenke)). </details> <details> <summary>shalzz/zola-deploy-action (shalzz/zola-deploy-action)</summary> ### [`v0.19.1`](https://togithub.com/shalzz/zola-deploy-action/releases/tag/v0.19.1) [Compare Source](https://togithub.com/shalzz/zola-deploy-action/compare/v0.18.0...v0.19.1) #### What's Changed - create .nojekyll file in OUT_DIR by [@​eugene-babichenko](https://togithub.com/eugene-babichenko) in [https://github.com/shalzz/zola-deploy-action/pull/84](https://togithub.com/shalzz/zola-deploy-action/pull/84) #### New Contributors - [@​eugene-babichenko](https://togithub.com/eugene-babichenko) made their first contribution in [https://github.com/shalzz/zola-deploy-action/pull/84](https://togithub.com/shalzz/zola-deploy-action/pull/84) **Full Changelog**: shalzz/zola-deploy-action@v0.18.0...v0.19.1 </details> <details> <summary>grpc/grpc-java (io.grpc:grpc-stub)</summary> ### [`v1.65.0`](https://togithub.com/grpc/grpc-java/compare/v1.64.0...v1.65.0) ### [`v1.64.1`](https://togithub.com/grpc/grpc-java/releases/tag/v1.64.1) ##### What's Changed - netty:Fix Netty composite buffer merging to be compatible with Netty 4.1.111 (1.64.x backport) by [@​larry-safran](https://togithub.com/larry-safran) in [https://github.com/grpc/grpc-java/pull/11303](https://togithub.com/grpc/grpc-java/pull/11303) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/TBD54566975/ftl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-pb-java
Jul 1, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.grpc:protoc-gen-grpc-java](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | | [io.grpc:grpc-testing](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | | [io.grpc:grpc-netty-shaded](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | | [io.grpc:grpc-stub](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | | [io.grpc:grpc-services](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | | [io.grpc:grpc-protobuf](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | --- ### Release Notes <details> <summary>grpc/grpc-java (io.grpc:protoc-gen-grpc-java)</summary> ### [`v1.65.0`](https://togithub.com/grpc/grpc-java/releases/tag/v1.65.0) grpc-netty in this release is compatible with Netty 4.1.111; it fixes the incompatibility that caused data corruption. grpc-netty-shaded is still using Netty 4.1.100. ##### New Features - New module grpc-gcp-csm-observability ([`df8cfe9`](https://togithub.com/grpc/grpc-java/commit/df8cfe9dd)) ##### Improvements - api: Add `ClientStreamTracer.inboundHeaders(Metadata)` ([`960012d`](https://togithub.com/grpc/grpc-java/commit/960012d76)). This is the same as the existing `inboundHeaders()`, but is provided the Metadata - api: Fix various typos in the documentation ([#​11144](https://togithub.com/grpc/grpc-java/issues/11144)) ([`6ec744f`](https://togithub.com/grpc/grpc-java/commit/6ec744f2a)) - core: When queuing RPCs, don’t request picks from the LB twice ([`8844cf7`](https://togithub.com/grpc/grpc-java/commit/8844cf7b8)). This could be viewed as a small performance optimization, but mainly reduces the amount of race-handling code - util: Improve AdvancedTlsX509KeyManager’s documentation, verification, and testing. ([#​11139](https://togithub.com/grpc/grpc-java/issues/11139)) ([`781b4c4`](https://togithub.com/grpc/grpc-java/commit/781b4c457)) This change shows `@ExperimentalApi` being removed, but it was re-added in [`3c97245`](https://togithub.com/grpc/grpc-java/commit/3c97245) before the release - examples: Fix broken command in reflection readme ([#​11131](https://togithub.com/grpc/grpc-java/issues/11131)) ([`c31dbf4`](https://togithub.com/grpc/grpc-java/commit/c31dbf48a)) - binder: Add a connection timeout ([#​11255](https://togithub.com/grpc/grpc-java/issues/11255)) ([`791f894`](https://togithub.com/grpc/grpc-java/commit/791f894e2)) ##### Bug fixes - core: Exit idle mode when delayed transport is in use ([`fea577c`](https://togithub.com/grpc/grpc-java/commit/fea577c80)). This was a long-standing race that could cause RPCs to hang, but was very unlikely to be hit. Avoiding the double-picking ([`8844cf7`](https://togithub.com/grpc/grpc-java/commit/8844cf7b8)) made the race more visible - netty: Fix Netty composite buffer merging to be compatible with Netty 4.1.111 ([#​11294](https://togithub.com/grpc/grpc-java/issues/11294)) ([`0fea7dd`](https://togithub.com/grpc/grpc-java/commit/0fea7dd)). The previous behavior easily caused data corruption - okhttp: Workaround SSLSocket not noticing socket is closed ([`a28357e`](https://togithub.com/grpc/grpc-java/commit/a28357e19)). Previously, shutting down when a new connection was being established could result in the server never becoming terminated - inprocess: Fix listener race if transport is shutdown while starting ([`e4e7f3a`](https://togithub.com/grpc/grpc-java/commit/e4e7f3a06)). This issue was unlikely to be hit outside of specialized tests - services: restore //services:binarylog bazel target ([#​11292](https://togithub.com/grpc/grpc-java/issues/11292)) ([`d57f271`](https://togithub.com/grpc/grpc-java/commit/d57f271)). This fixes a regression introduced in 1.62.2 - binder: Wait for all server transports to terminate before returning the security policy executor to the object pool ([#​11240](https://togithub.com/grpc/grpc-java/issues/11240)) ([`34ee600`](https://togithub.com/grpc/grpc-java/commit/34ee600dc)) - binder: Reject further SETUP_TRANSPORT requests post-BinderServer shutdown ([#​11260](https://togithub.com/grpc/grpc-java/issues/11260)) ([`1670e97`](https://togithub.com/grpc/grpc-java/commit/1670e97f7)) - bazel: Include missing com_google_protobuf_javalite in MODULE.bazel ([#​11147](https://togithub.com/grpc/grpc-java/issues/11147)) ([`f995c12`](https://togithub.com/grpc/grpc-java/commit/f995c121e)) ##### Thanks to [@​hakusai22](https://togithub.com/hakusai22) [@​firov](https://togithub.com/firov) [@​mateusazis](https://togithub.com/mateusazis) [@​Mir3605](https://togithub.com/Mir3605) [@​niloc132](https://togithub.com/niloc132) ### [`v1.64.1`](https://togithub.com/grpc/grpc-java/releases/tag/v1.64.1) ##### What's Changed - netty:Fix Netty composite buffer merging to be compatible with Netty 4.1.111 (1.64.x backport) by [@​larry-safran](https://togithub.com/larry-safran) in [https://github.com/grpc/grpc-java/pull/11303](https://togithub.com/grpc/grpc-java/pull/11303) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMyIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-sdk-java
Jul 1, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.grpc:grpc-inprocess](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | | [io.grpc:grpc-testing](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | | [io.grpc:grpc-services](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | | [io.grpc:grpc-stub](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | | [io.grpc:grpc-protobuf](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.64.0` -> `1.65.0` | --- ### Release Notes <details> <summary>grpc/grpc-java (io.grpc:grpc-inprocess)</summary> ### [`v1.65.0`](https://togithub.com/grpc/grpc-java/releases/tag/v1.65.0) grpc-netty in this release is compatible with Netty 4.1.111; it fixes the incompatibility that caused data corruption. grpc-netty-shaded is still using Netty 4.1.100. ##### New Features - New module grpc-gcp-csm-observability ([`df8cfe9`](https://togithub.com/grpc/grpc-java/commit/df8cfe9dd)) ##### Improvements - api: Add `ClientStreamTracer.inboundHeaders(Metadata)` ([`960012d`](https://togithub.com/grpc/grpc-java/commit/960012d76)). This is the same as the existing `inboundHeaders()`, but is provided the Metadata - api: Fix various typos in the documentation ([#​11144](https://togithub.com/grpc/grpc-java/issues/11144)) ([`6ec744f`](https://togithub.com/grpc/grpc-java/commit/6ec744f2a)) - core: When queuing RPCs, don’t request picks from the LB twice ([`8844cf7`](https://togithub.com/grpc/grpc-java/commit/8844cf7b8)). This could be viewed as a small performance optimization, but mainly reduces the amount of race-handling code - util: Improve AdvancedTlsX509KeyManager’s documentation, verification, and testing. ([#​11139](https://togithub.com/grpc/grpc-java/issues/11139)) ([`781b4c4`](https://togithub.com/grpc/grpc-java/commit/781b4c457)) This change shows `@ExperimentalApi` being removed, but it was re-added in [`3c97245`](https://togithub.com/grpc/grpc-java/commit/3c97245) before the release - examples: Fix broken command in reflection readme ([#​11131](https://togithub.com/grpc/grpc-java/issues/11131)) ([`c31dbf4`](https://togithub.com/grpc/grpc-java/commit/c31dbf48a)) - binder: Add a connection timeout ([#​11255](https://togithub.com/grpc/grpc-java/issues/11255)) ([`791f894`](https://togithub.com/grpc/grpc-java/commit/791f894e2)) ##### Bug fixes - core: Exit idle mode when delayed transport is in use ([`fea577c`](https://togithub.com/grpc/grpc-java/commit/fea577c80)). This was a long-standing race that could cause RPCs to hang, but was very unlikely to be hit. Avoiding the double-picking ([`8844cf7`](https://togithub.com/grpc/grpc-java/commit/8844cf7b8)) made the race more visible - netty: Fix Netty composite buffer merging to be compatible with Netty 4.1.111 ([#​11294](https://togithub.com/grpc/grpc-java/issues/11294)) ([`0fea7dd`](https://togithub.com/grpc/grpc-java/commit/0fea7dd)). The previous behavior easily caused data corruption - okhttp: Workaround SSLSocket not noticing socket is closed ([`a28357e`](https://togithub.com/grpc/grpc-java/commit/a28357e19)). Previously, shutting down when a new connection was being established could result in the server never becoming terminated - inprocess: Fix listener race if transport is shutdown while starting ([`e4e7f3a`](https://togithub.com/grpc/grpc-java/commit/e4e7f3a06)). This issue was unlikely to be hit outside of specialized tests - services: restore //services:binarylog bazel target ([#​11292](https://togithub.com/grpc/grpc-java/issues/11292)) ([`d57f271`](https://togithub.com/grpc/grpc-java/commit/d57f271)). This fixes a regression introduced in 1.62.2 - binder: Wait for all server transports to terminate before returning the security policy executor to the object pool ([#​11240](https://togithub.com/grpc/grpc-java/issues/11240)) ([`34ee600`](https://togithub.com/grpc/grpc-java/commit/34ee600dc)) - binder: Reject further SETUP_TRANSPORT requests post-BinderServer shutdown ([#​11260](https://togithub.com/grpc/grpc-java/issues/11260)) ([`1670e97`](https://togithub.com/grpc/grpc-java/commit/1670e97f7)) - bazel: Include missing com_google_protobuf_javalite in MODULE.bazel ([#​11147](https://togithub.com/grpc/grpc-java/issues/11147)) ([`f995c12`](https://togithub.com/grpc/grpc-java/commit/f995c121e)) ##### Thanks to [@​hakusai22](https://togithub.com/hakusai22) [@​firov](https://togithub.com/firov) [@​mateusazis](https://togithub.com/mateusazis) [@​Mir3605](https://togithub.com/Mir3605) [@​niloc132](https://togithub.com/niloc132) ### [`v1.64.1`](https://togithub.com/grpc/grpc-java/releases/tag/v1.64.1) ##### What's Changed - netty:Fix Netty composite buffer merging to be compatible with Netty 4.1.111 (1.64.x backport) by [@​larry-safran](https://togithub.com/larry-safran) in [https://github.com/grpc/grpc-java/pull/11303](https://togithub.com/grpc/grpc-java/pull/11303) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMyIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
zhumin8
referenced
this pull request
in googleapis/sdk-platform-java
Jul 23, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-core](https://togithub.com/grpc/grpc-java) | `1.62.2` -> `1.65.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.grpc:grpc-core/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.grpc:grpc-core/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.grpc:grpc-core/1.62.2/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.grpc:grpc-core/1.62.2/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | `1.62.2` -> `1.65.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.grpc:grpc-bom/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.grpc:grpc-bom/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.grpc:grpc-bom/1.62.2/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.grpc:grpc-bom/1.62.2/1.65.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>grpc/grpc-java (io.grpc:grpc-core)</summary> ### [`v1.65.0`](https://togithub.com/grpc/grpc-java/compare/v1.64.0...v1.65.0) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.64.1...v1.65.0) ### [`v1.64.1`](https://togithub.com/grpc/grpc-java/releases/tag/v1.64.1) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.64.0...v1.64.1) ##### What's Changed - netty:Fix Netty composite buffer merging to be compatible with Netty 4.1.111 (1.64.x backport) by [@​larry-safran](https://togithub.com/larry-safran) in [https://github.com/grpc/grpc-java/pull/11303](https://togithub.com/grpc/grpc-java/pull/11303) ### [`v1.64.0`](https://togithub.com/grpc/grpc-java/releases/tag/v1.64.0) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.63.1...v1.64.0) ##### API Changes - compiler: the option `jakarta_omit` was renamed `@generated=omit` ([#​11086](https://togithub.com/grpc/grpc-java/issues/11086)) ([`8a21afc`](https://togithub.com/grpc/grpc-java/commit/8a21afcc9)) ##### New Features - New API LoadBalancer.getChannelTarget() ([`4561bb5`](https://togithub.com/grpc/grpc-java/commit/4561bb5b8)) - opentelemetry: Publish new module grpc-opentelemetry ([`5ba1a55`](https://togithub.com/grpc/grpc-java/commit/5ba1a5563)). The feature is still missing documentation and an example. It only supports metrics; tracing and logs will be future enhancements. See [gRFC A66](https://togithub.com/grpc/proposal/blob/master/A66-otel-stats.md) - bazel: Add support for bzlmod ([#​11046](https://togithub.com/grpc/grpc-java/issues/11046)) ([`d1890c0`](https://togithub.com/grpc/grpc-java/commit/d1890c0ac)) - bazel: Replace usages of the old compatibility maven targets with `@maven` targets ([`0064991`](https://togithub.com/grpc/grpc-java/commit/00649913b)) - okhttp: Support serverBuilder.maxConcurrentCallsPerConnection (Fixes [#​11062](https://togithub.com/grpc/grpc-java/issues/11062)). ([#​11063](https://togithub.com/grpc/grpc-java/issues/11063)) ([`8050723`](https://togithub.com/grpc/grpc-java/commit/805072339)) - xds: Experimental metrics recording in WRR LB ([`06df25b`](https://togithub.com/grpc/grpc-java/commit/06df25b65), [`35a171b`](https://togithub.com/grpc/grpc-java/commit/35a171bc1), [`2897b39`](https://togithub.com/grpc/grpc-java/commit/2897b3939)), to be exported by grpc-opentelemetry if explicitly enabled in GrpcOpenTelemetry. See [gRFC A78](https://togithub.com/grpc/proposal/blob/master/A78-grpc-metrics-wrr-pf-xds.md) - rls: Experimental metrics recording in RLS LB ([`a9fb272`](https://togithub.com/grpc/grpc-java/commit/a9fb272b7), [`a1d1932`](https://togithub.com/grpc/grpc-java/commit/a1d19327f), [`8133318`](https://togithub.com/grpc/grpc-java/commit/813331837)), to be exported by grpc-opentelemetry if explicitly enabled in GrpcOpenTelemetry ##### Improvements - examples: support bazel build for retry policy example ([`58de563`](https://togithub.com/grpc/grpc-java/commit/58de563fa)) - netty: Allow deframer errors to close stream with a status code, as long as headers have not yet been sent ([`e036b1b`](https://togithub.com/grpc/grpc-java/commit/e036b1b19)). This will greatly improve the debuggability of certain server errors in particular cases. Instead of the client seeing “CANCELLED: RST_STREAM closed stream. HTTP/2 error code: CANCEL”, they could see “RESOURCE_EXHAUSTED: gRPC message exceeds maximum size [`4194304`](https://togithub.com/grpc/grpc-java/commit/4194304): [`6144592`](https://togithub.com/grpc/grpc-java/commit/6144592)” - netty: Improve handling of unexpected write queue promise failures ([#​11016](https://togithub.com/grpc/grpc-java/issues/11016)) - servlet: Avoid unnecessary FINEST hex string conversion by checking log level. Fixes [#​11031](https://togithub.com/grpc/grpc-java/issues/11031). ([`f7ee5f3`](https://togithub.com/grpc/grpc-java/commit/f7ee5f318)) - StatusException/StatusRuntimeException hide stack trace in a simpler way ([#​11064](https://togithub.com/grpc/grpc-java/issues/11064)) ([`e36f099`](https://togithub.com/grpc/grpc-java/commit/e36f099be)) - util: Status desc for outlier detection ejection ([#​11036](https://togithub.com/grpc/grpc-java/issues/11036)) ([`10cb4a3`](https://togithub.com/grpc/grpc-java/commit/10cb4a3be)) - binder: Helper class to allow in process servers to use peer uids in test ([#​11014](https://togithub.com/grpc/grpc-java/issues/11014)) ([`537dbe8`](https://togithub.com/grpc/grpc-java/commit/537dbe826)) - Add `load()` statements for the Bazel builtin top-level java symbols ([#​11105](https://togithub.com/grpc/grpc-java/issues/11105)) ([`add8c37`](https://togithub.com/grpc/grpc-java/commit/add8c37a4)) - Add `StatusProto.toStatusException` overload to accept `Throwable` ([#​11083](https://togithub.com/grpc/grpc-java/issues/11083)) ([`5c9b492`](https://togithub.com/grpc/grpc-java/commit/5c9b49231)) ##### Bug fixes - Fix retry race condition that can lead to double decrementing inFlightSubStreams and so miss calling closed ([#​11026](https://togithub.com/grpc/grpc-java/issues/11026)) ([`bdb6230`](https://togithub.com/grpc/grpc-java/commit/bdb623031)) - Change defaults to use the older PickFirstLoadBalancer and disable Happy Eyeballs. This disables a performance optimization added in v1.63. ([#​11120](https://togithub.com/grpc/grpc-java/issues/11120)) We have had a report that the new implementation can trigger a NullPointerException - core: Transition to CONNECTING immediately when exiting idle ([`2c5f0c2`](https://togithub.com/grpc/grpc-java/commit/2c5f0c22c)). Previously the visible state change from `channel.getState()` was delayed until the name resolver returned results. This had no impact to RPC behavior - xds: Specify a locale for upper/lower case conversions ([`e630593`](https://togithub.com/grpc/grpc-java/commit/e6305930d)) - rls: Synchronization fixes in CachingRlsLbClient ([`6e97b18`](https://togithub.com/grpc/grpc-java/commit/6e97b180b)). These races had not been witnessed in practice - rls: Guarantee backoff will update RLS picker ([`f9b6e5f`](https://togithub.com/grpc/grpc-java/commit/f9b6e5f92)). This fixes a regression introduced by [`6e97b18`](https://togithub.com/grpc/grpc-java/commit/6e97b180b) that could hang RPCs instead of using fallback, but fixes a pre-existing bug that could greatly delay RPCs from using fallback. - rls: Fix time handling in CachingRlsLbClient ([`da619e2`](https://togithub.com/grpc/grpc-java/commit/da619e2bd)). This could have caused backoff entries to improperly be considered expired - xds: Properly disable the default endpoint identification algorithm with XdsChannelCredentials ([`097a46b`](https://togithub.com/grpc/grpc-java/commit/097a46b76)). The credential does its own verification and the default needs to be disabled for SPIFFE - netty: Release SendGrpcFrameCommand when stream is missing ([#​11116](https://togithub.com/grpc/grpc-java/issues/11116)) ([`fb9a108`](https://togithub.com/grpc/grpc-java/commit/fb9a10809)) - okhttp: Remove finished stream even if a pending stream was started ([`d21fe32`](https://togithub.com/grpc/grpc-java/commit/d21fe32be)) ##### Dependencies - cronet: Update Cronet to latest release + Move to Stable Cronet APIs. ([`5a8da19`](https://togithub.com/grpc/grpc-java/commit/5a8da19f3)) - cronet: [@​javadoc](https://togithub.com/javadoc) update android permission MODIFY_NETWORK_ACCOUNTING (deprecated) => UPDATE_DEVICE_STATS ([`c703a1e`](https://togithub.com/grpc/grpc-java/commit/c703a1ee0)) - cronet: Update to Java-8 API's and tighten the scopes ([`163efa3`](https://togithub.com/grpc/grpc-java/commit/163efa371)) - cronet: Update to StandardCharsets and assertNotNull API's ([`77e59b2`](https://togithub.com/grpc/grpc-java/commit/77e59b29d)) ##### Acknowledgements [@​panchenko](https://togithub.com/panchenko) [@​Ashok-Varma](https://togithub.com/Ashok-Varma) [@​benjaminp](https://togithub.com/benjaminp) [@​AutomatedTester](https://togithub.com/AutomatedTester) [@​hypnoce](https://togithub.com/hypnoce) [@​keith](https://togithub.com/keith) [@​laglangyue](https://togithub.com/laglangyue) [@​rostik404](https://togithub.com/rostik404) [@​ryanpbrewster](https://togithub.com/ryanpbrewster) [@​abtom](https://togithub.com/abtom) [@​hvadehra](https://togithub.com/hvadehra) [@​rtadepalli](https://togithub.com/rtadepalli) ### [`v1.63.1`](https://togithub.com/grpc/grpc-java/releases/tag/v1.63.1) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.63.0...v1.63.1) ##### Bug fixes - netty: Release SendGrpcFrameCommand when stream is missing ([#​11116](https://togithub.com/grpc/grpc-java/issues/11116)) ([`fb9a108`](https://togithub.com/grpc/grpc-java/commit/fb9a10809)) - Change defaults to use the older PickFirstLoadBalancer and disable Happy Eyeballs. This disables a performance optimization added in v1.63.0 ([#​11120](https://togithub.com/grpc/grpc-java/issues/11120)) We have had a report that the new implementation can trigger a NullPointerException ### [`v1.63.0`](https://togithub.com/grpc/grpc-java/releases/tag/v1.63.0) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.62.2...v1.63.0) ##### API Changes - xds: Stabilize CsdsService ([#​11003](https://togithub.com/grpc/grpc-java/issues/11003)) ([`0d749c5`](https://togithub.com/grpc/grpc-java/commit/0d749c594)) - api: Stabilize server.getListenerSockets ([#​10910](https://togithub.com/grpc/grpc-java/issues/10910)) ([`ff34d51`](https://togithub.com/grpc/grpc-java/commit/ff34d51c7)) - servlet: Introduce ServletServerBuilder.buildServlet([#​10921](https://togithub.com/grpc/grpc-java/issues/10921)) ([`257d1c2`](https://togithub.com/grpc/grpc-java/commit/257d1c2db)) - api: Allow configuration of the queued byte threshold at which a Stream is considered not ready ([#​10977](https://togithub.com/grpc/grpc-java/issues/10977)) ([`2c83ef0`](https://togithub.com/grpc/grpc-java/commit/2c83ef063)) ##### New Features xds, dual stack, happy eyeballs: Support dual stack in xds, change list includes: - Enable new PickFirst lb policy by default. The new PickFirst implements subchannel picking logic. ([#​11002](https://togithub.com/grpc/grpc-java/issues/11002)) ([`8a9ce99`](https://togithub.com/grpc/grpc-java/commit/8a9ce990b)) - EDS resource now supports additional addresses ([#​11011](https://togithub.com/grpc/grpc-java/issues/11011)) ([`38f968f`](https://togithub.com/grpc/grpc-java/commit/38f968faf)) - Change address based outlier detection to endpoint based ([#​10939](https://togithub.com/grpc/grpc-java/issues/10939)) ([`c61fe69`](https://togithub.com/grpc/grpc-java/commit/c61fe6980)) - Enable Happy Eyeballs by default ([#​11022](https://togithub.com/grpc/grpc-java/issues/11022)) ([`51f811d`](https://togithub.com/grpc/grpc-java/commit/51f811df8)) ##### Improvements - rls: Adding extra debug logs ([#​10902](https://togithub.com/grpc/grpc-java/issues/10902)) ([`eba699a`](https://togithub.com/grpc/grpc-java/commit/eba699ad1)) - binder: Add missing Android API annotations ([#​10841](https://togithub.com/grpc/grpc-java/issues/10841)) ([`ce2adcc`](https://togithub.com/grpc/grpc-java/commit/ce2adcca9)) - core: Provide DEADLINE_EXCEEDED insights for context deadline ([`3abab95`](https://togithub.com/grpc/grpc-java/commit/3abab95e7)). When the deadline triggered and the deadline was set on the RPC via the stub or CallOptions, gRPC would gather additional debugging information to help understand where the RPC took so long. However if the deadline came from io.grpc.Context the error was simply “context timed out.” Now the debugging information is provided in both cases - examples: Fix file paths in debug example README ([`e19f1f1`](https://togithub.com/grpc/grpc-java/commit/e19f1f15a)) - compiler: implement ability to skip generation of javax annotation ([#​10927](https://togithub.com/grpc/grpc-java/issues/10927)) ([`0d39c2c`](https://togithub.com/grpc/grpc-java/commit/0d39c2c70)). Pass the option `jakarta_omit` to protoc-gen-grpc-java when generating code - xds: Get rid of xDS v2 proto dependencies ([#​10968](https://togithub.com/grpc/grpc-java/issues/10968)) ([`feab4e5`](https://togithub.com/grpc/grpc-java/commit/feab4e544)). `grpc-xds` jar size has decreased by 35%. - xds: Support retrieving names from wrapped resource containers ([#​10975](https://togithub.com/grpc/grpc-java/issues/10975)) ([`867e469`](https://togithub.com/grpc/grpc-java/commit/867e46940)) - netty: improve server handling of writes to reset streams ([#​10258](https://togithub.com/grpc/grpc-java/issues/10258)) ([`a68399a`](https://togithub.com/grpc/grpc-java/commit/a68399a9b)) - api: Fix a typo in ServerInterceptor JavaDoc ([#​10990](https://togithub.com/grpc/grpc-java/issues/10990)) ([`0b82f01`](https://togithub.com/grpc/grpc-java/commit/0b82f0126)) - servlet: Check log fine level before hex string conversion. ([#​11038](https://togithub.com/grpc/grpc-java/issues/11038)) - auth: Specify a locale for upper/lower case conversions (1.63.x backport) [#​11050](https://togithub.com/grpc/grpc-java/issues/11050) ##### Bug Fixes - xds: Copy data in least request to avoid picker data race ([`f4cc166`](https://togithub.com/grpc/grpc-java/commit/f4cc166f1)). This fixes a possible regression introduced in 1.60.0. Auditing the buggy code showed it unlikely to cause problems in practice, but that was more by happenstance than by design - xds: Fix data race in the xds client that contacts the control plane ([`d7628a3`](https://togithub.com/grpc/grpc-java/commit/d7628a3ab)) - rls: Fix a local and remote race ([`aa90768`](https://togithub.com/grpc/grpc-java/commit/aa9076812)). The remote race could cause an RPC to hang until its deadline. It had been seen in practice when the client was severely CPU under-provisioned - xds: Fix xdsNameResolver virtual host lookup authority with xdstp style names. Use service authority instead of ldsResourceName ([#​10960](https://togithub.com/grpc/grpc-java/issues/10960)) ([`78b3972`](https://togithub.com/grpc/grpc-java/commit/78b3972ff)) - core: Fix retry race condition that can lead to double decrementing inFlightSubStreams and so miss calling closed ([#​11026](https://togithub.com/grpc/grpc-java/issues/11026)) ([#​11033](https://togithub.com/grpc/grpc-java/issues/11033)) - okhttp: Fix OkHTTP client transport leak ([#​11060](https://togithub.com/grpc/grpc-java/issues/11060)) - xds: Use empty string when disabling server hostname verification ( [#​11058](https://togithub.com/grpc/grpc-java/issues/11058)) ##### Dependencies - Upgraded google-auth-library-java to 1.22.0 ##### Acknowledgement Alex Panchenko Benjamin Peterson David Ankin Prashanth Swaminathan Touko Vainio-Kaila </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: Min Zhu <[email protected]> Co-authored-by: Blake Li <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the logic for identifying changes to the read index when merging into a netty composite buffer so that it works with both older versions of netty and netty 4.1.111
Fixes #11284
Backport of #11294