Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: restore //services:binarylog bazel target #11292

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Jun 14, 2024

The target was wrongly deleted in 75492c8 / #10832.
See details in #4017 (comment).

@sergiitk sergiitk requested a review from ejona86 June 14, 2024 21:55
The target was wrongly deleted in 75492c8.
See details in grpc#4017 (comment).
@sergiitk
Copy link
Member Author

Rebase FYI - commit message reword.

@sergiitk sergiitk marked this pull request as draft June 14, 2024 22:04
@sergiitk sergiitk marked this pull request as ready for review June 14, 2024 22:08
@sergiitk
Copy link
Member Author

FYI @rob-pomelo

@sergiitk
Copy link
Member Author

@ejona86 any objections?

@sergiitk sergiitk merged commit d57f271 into grpc:master Jun 20, 2024
13 checks passed
@sergiitk sergiitk deleted the 4017-restore-bazel branch June 20, 2024 22:40
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Jun 21, 2024
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Jun 24, 2024
ejona86 pushed a commit that referenced this pull request Jun 26, 2024
@kannanjgithub
Copy link
Contributor

Removing the backport label as it has been done to 1.65.x.

@kannanjgithub kannanjgithub removed the TODO:backport PR needs to be backported. Removed after backport complete label Aug 6, 2024
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Aug 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants