V1reflectionservice #11237
Merged
V1reflectionservice #11237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes still in progress on the proto field mapping.
…the ServerServiceDefinition.
…rverServiceDefinition constructed from that of the v1 service but with the service and method names and proto descriptors modified.
…rverServiceDefinition constructed from that of the v1 service but with the service and method names and proto descriptors modified. Issue grpc#6724. Squashed commit of the following: commit f1f2da7 Author: Kannan J <[email protected]> Date: Tue May 28 10:24:32 2024 +0000 Some nitty changes. commit 34f81e5 Author: Kannan J <[email protected]> Date: Tue May 28 10:09:49 2024 +0000 Create ProtoReflectionService for the v1alpha proto by producing a ServerServiceDefinition constructed from that of the v1 service but with the service and method names and proto descriptors modified. commit e99a8da Author: Kannan J <[email protected]> Date: Fri May 24 11:20:28 2024 +0000 Create V1 alpha service wrapping underlying V1 service, by modifying the ServerServiceDefinition. commit b2bb9e1 Author: Kannan J <[email protected]> Date: Fri May 24 07:14:42 2024 +0000 Changes to allow unit testing. commit a002bc2 Author: Kannan J <[email protected]> Date: Wed May 22 11:53:27 2024 +0000 Issue grpc#6724 to create a V1 reflection service. Changes still in progress on the proto field mapping.
…ectionservice # Conflicts: # services/src/main/java/io/grpc/protobuf/services/ProtoReflectionService.java
ejona86
reviewed
May 28, 2024
interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java
Show resolved
Hide resolved
services/src/main/java/io/grpc/protobuf/services/util/ReflectionServiceProtoAdapter.java
Outdated
Show resolved
Hide resolved
services/src/main/java/io/grpc/protobuf/services/util/ReflectionServiceProtoAdapter.java
Outdated
Show resolved
Hide resolved
services/src/main/java/io/grpc/protobuf/services/ProtoReflectionService.java
Outdated
Show resolved
Hide resolved
services/src/main/java/io/grpc/protobuf/services/ProtoReflectionService.java
Outdated
Show resolved
Hide resolved
services/src/main/java/io/grpc/protobuf/services/ProtoReflectionService.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
May 29, 2024
interop-testing/src/main/java/io/grpc/testing/integration/XdsTestServer.java
Show resolved
Hide resolved
services/src/main/java/io/grpc/protobuf/services/ProtoReflectionService.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
May 30, 2024
| * extension. | ||
| */ | ||
| @ExperimentalApi("https://github.com/grpc/grpc-java/issues/2222") | ||
| public final class ProtoReflectionServiceV1 extends ServerReflectionGrpc.ServerReflectionImplBase { |
There was a problem hiding this comment.
As a follow-up PR, we'll want to remove the "extends ServerReflectionImplBase" from the public API surface. Yes, nobody can use it, but let's still not expose it. That is better as a follow-up, so that git will see the move/copy and then separately the changes made to the service.
ejona86
approved these changes
May 30, 2024
/grpc-java/services/src/main/java/io/grpc/protobuf/services/ProtoReflectionService.java:76: warning: [unchecked] unchecked method invocation: method addMethod in class Builder is applied to given types
.addMethod(methodDescriptorV1Alpha, createServerCallHandler(serverServiceDefinitionV1))
^
required: MethodDescriptor,ServerCallHandler
found: MethodDescriptor,ServerCallHandler
where ReqT,RespT are type-variables:
ReqT extends Object declared in method addMethod(MethodDescriptor,ServerCallHandler)
RespT extends Object declared in method addMethod(MethodDescriptor,ServerCallHandler)
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 13, 2024
V1 version of the proto reflection service, as the v1.alpha service has been deprecated. * Create V1 alpha service wrapping underlying V1 service, by modifying the ServerServiceDefinition. * Create ProtoReflectionService for the v1alpha proto by producing a ServerServiceDefinition constructed from that of the v1 service but with the service and method names and proto descriptors modified. Issue grpc#6724.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted existing ProtoReflectionService for v1.alpha to handle v1 protos and renamed it to ProtoReflectionServiceV1, and created a new ProtoReflectionService for v1.alpha that uses the V1 service's ServerServiceDefinition and modifies the names and proto descriptors for service and method.
Issue #6724.