context, all: move Context classes to grpc-api #10313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean up grpc-context since it has no source code: only add dep on grpc-api add exclusion for all transitive deps of grpc-api - only guava exclude grpc-context as a dependency from grpc-alts because all context code is in grpc-api now api: 1.7 as target Java version for Context source-set of grpc-api
larry-safran
approved these changes
Jun 26, 2023
ejona86
reviewed
Jun 26, 2023
|
We'll need to make sure Context is in the sources jar and the javadoc. Mirror #10315 for the sources jar. Javadoc would look something like: tasks.named("javadoc").configure {
source sourceSets.context.allSource
} |
|
Addressed all review comments so far, but changes for bazel failures are still pending. |
… code moving from context to api
|
@ejona86 addressed all your comments and fixed bazel build. Also all tests have passed. PTAL. Thx |
ejona86
approved these changes
Jun 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up grpc-context since it has no source code: only add dep on grpc-api.
add exclusion for all transitive deps of grpc-api - only guava.
exclude grpc-context as a dependency from grpc-alts because all context code is in grpc-api now
api: 1.7 as target Java version for Context source-set of grpc-api
Fixes #3522