Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildscripts, psm interop: Don't fail target if sub-target already failed #10232

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

XuanWang-Amos
Copy link
Contributor

@XuanWang-Amos XuanWang-Amos commented May 31, 2023

We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.
The same change in core: grpc/grpc#33222.

@XuanWang-Amos XuanWang-Amos changed the title Don't fail target if sub-target already failed [PSM interop] Don't fail target if sub-target already failed May 31, 2023
@sergiitk sergiitk self-requested a review May 31, 2023 23:55
@sergiitk sergiitk enabled auto-merge (squash) June 1, 2023 00:00
@sergiitk sergiitk disabled auto-merge June 1, 2023 00:02
@sergiitk sergiitk changed the title [PSM interop] Don't fail target if sub-target already failed buildscripts, psm interop: Don't fail target if sub-target already failed Jun 1, 2023
@sergiitk sergiitk enabled auto-merge (squash) June 1, 2023 00:13
@sergiitk sergiitk disabled auto-merge June 1, 2023 00:13
@sergiitk sergiitk enabled auto-merge (squash) June 1, 2023 00:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants