gcp observability: Update Docker images to eclipse-temurin #10218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adhoc test run to make sure the Observability Integration tests are still green: http://sponge/2e8c6d78-8f55-4d2a-baf7-4ba04c1f41ad |
|
FYI @sergiitk |
ejona86
reviewed
May 25, 2023
|
|
||
| WORKDIR /grpc-java | ||
| COPY . . | ||
|
|
||
| # Intentionally after the app COPY to force the update on each build. |
There was a problem hiding this comment.
This doesn't do what you think it does, because this isn't part of the final image.
sergiitk
requested changes
May 25, 2023
|
|
||
| WORKDIR /grpc-java | ||
| COPY . . | ||
|
|
||
| # Intentionally after the app COPY to force the update on each build. | ||
| # Update Ubuntu system packages: |
There was a problem hiding this comment.
Yes - this needs to be moved to the second stage of the build.
There was a problem hiding this comment.
Done. Thanks for the comment.
ejona86
approved these changes
May 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sergii noticed that the GCP Observability Integration testing docker image in the
microsvcs-testingproject popped up on the vulnerabilities dashboard. So we need to fix which base docker image we use. Similar to the fix in #10191