mem: use slice capacity instead of length, to determine whether to pool buffers or directly allocate them #7702
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
PapaCharlie
force-pushed
the
pc/poolshortbuffers
branch
from
1ab352d
to
5d2cb0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7702 +/- ##
==========================================
+ Coverage 81.80% 81.88% +0.07%
==========================================
Files 361 361
Lines 27827 27827
==========================================
+ Hits 22765 22786 +21
+ Misses 3861 3848 -13
+ Partials 1201 1193 -8
|
As the issue states, `mem.NewBuffer` would not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked.
PapaCharlie
force-pushed
the
pc/poolshortbuffers
branch
from
5d2cb0c
to
aed354b
Compare
easwars
changed the title
easwars
approved these changes
Oct 8, 2024
Comment on lines
+95
to
+97
| // Use the buffer's capacity instead of the length, otherwise buffers may not be reused under certain | ||
| // conditions. For example, if a large buffer is acquired from the pool, but fewer bytes than the | ||
| // buffering threshold are written to it, the buffer will not be returned to the pool. |
There was a problem hiding this comment.
Nit: Can you please wrap the comment lines, here and elsewhere in this PR, to 80-cols. Thanks.
| mem.NewBuffer(&b, pool).Free() | ||
|
|
||
| if pool.data != nil { | ||
| t.Fatalf("buffer not returned to pool") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7631
As the issue states,
mem.NewBufferwould not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked.RELEASE NOTES: