Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #7664 to v1.67.x branch #7681

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Sep 30, 2024

Original PR: #7664
Addresses: #7657

RELEASE NOTES:

  • xds/server: Fix xDS Server memory leak

@arjan-bal arjan-bal added this to the 1.67 Release milestone Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.77%. Comparing base (935f8cb) to head (d826085).
Report is 1 commits behind head on v1.67.x.

Files with missing lines Patch % Lines
xds/internal/server/listener_wrapper.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.67.x    #7681      +/-   ##
===========================================
- Coverage    81.88%   81.77%   -0.12%     
===========================================
  Files          361      361              
  Lines        27813    27817       +4     
===========================================
- Hits         22776    22748      -28     
- Misses        3844     3864      +20     
- Partials      1193     1205      +12     
Files with missing lines Coverage Δ
xds/internal/server/conn_wrapper.go 77.04% <100.00%> (-4.62%) ⬇️
xds/internal/server/listener_wrapper.go 79.01% <93.33%> (+0.39%) ⬆️

... and 23 files with indirect coverage changes

@arjan-bal arjan-bal assigned arjan-bal and unassigned purnesh42H Sep 30, 2024
@arjan-bal arjan-bal merged commit 4f6c5f2 into grpc:v1.67.x Sep 30, 2024
14 checks passed
@arjan-bal arjan-bal deleted the cherrypick/7664 branch September 30, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants