[Pre-1.0 Semantics Change] Support Fail-fast and make it the default setup #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| // All the remaining cases are treated as retryable. | ||
| continue | ||
| // ALl the other errors are treated as Internal errors. |
There was a problem hiding this comment.
capitalization here is weird
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with what gRPC C/C++ does. For the definition of fail-fast, please refer to https://github.com/grpc/grpc/blob/master/doc/fail_fast.md for detail.
Once this pull request is in, it might break your project because by default gRPC internals stops retrying on the network errors. You can simply add grpc.FailFast(false) into your unary/streaming RPC call as a grpc.CallOption to fix the problem.
Sorry for the semantics change.