Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport: add timeout for writing GOAWAY on http2Client.Close() #7371

Merged
merged 19 commits into from
Aug 16, 2024
Merged

transport: add timeout for writing GOAWAY on http2Client.Close() #7371

merged 19 commits into from
Aug 16, 2024

Commits on Aug 13, 2024

  1. fix: add timeout for loopy writer wait to close itself

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    6c316d6 View commit details
    Browse the repository at this point in the history

  2. refactor: resolved suggestions from purnesh

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    284f45b View commit details
    Browse the repository at this point in the history

  3. remove hangingConn logic

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    44d0979 View commit details
    Browse the repository at this point in the history

  4. Undo refactor

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    73da571 View commit details
    Browse the repository at this point in the history

  5. resolved easwar's comments: refactored server code in test and comments

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b083d8c View commit details
    Browse the repository at this point in the history

  6. fixed easwars comment: put ct.Close in goroutine

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2525c9b View commit details
    Browse the repository at this point in the history

  7. update test method with easwar's code

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    cd7b716 View commit details
    Browse the repository at this point in the history

  8. don't use time.After() in non-test code to make vet happy

    @easwars @aranjans
    easwars authored and aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    bc66ca9 View commit details
    Browse the repository at this point in the history

  9. fix: replace Warning with Infof

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8ffe575 View commit details
    Browse the repository at this point in the history

  10. fix: add hanging conn dialer

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a684542 View commit details
    Browse the repository at this point in the history

  11. fixed race condition in test

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    59cc230 View commit details
    Browse the repository at this point in the history

  12. Decouple error logic with timer logic waiting for loopy

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b9a16d4 View commit details
    Browse the repository at this point in the history

  13. Remove redundant overridden methods of hangingConn

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3ec2ccb View commit details
    Browse the repository at this point in the history

  14. fixed nits

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4a6bcf5 View commit details
    Browse the repository at this point in the history

  15. Make isGreetingDone part of hangingConn struct

    @aranjans
    aranjans committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    205fbdf View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. fixed nits

    @aranjans
    aranjans committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a7a7bb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Set write deadline for net.Conn

    @aranjans
    aranjans committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9636c56 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. remove timer for hc.Write

    @aranjans
    aranjans committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    aebe562 View commit details
    Browse the repository at this point in the history

  2. Revert the atomic boolean for hangingConn.Write()

    @aranjans
    aranjans committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    fad99ba View commit details
    Browse the repository at this point in the history