Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/xds: minor cleanup in xDS e2e test #5843

Merged

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Dec 5, 2022

Addresses a test issue leading to some flakiness in #5231.

RELEASE NOTES: none

@easwars easwars requested a review from zasweq December 5, 2022 19:47
@easwars easwars added this to the 1.52 Release milestone Dec 5, 2022
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@easwars easwars force-pushed the TestUnmarshalListener_WithUpdateValidatorFunc branch from 7d905aa to f49f2d9 Compare December 9, 2022 00:30
@easwars easwars force-pushed the TestUnmarshalListener_WithUpdateValidatorFunc branch from 1b56fed to 76b8763 Compare December 9, 2022 00:47
@easwars easwars merged commit f54bba9 into grpc:master Dec 9, 2022
@easwars easwars deleted the TestUnmarshalListener_WithUpdateValidatorFunc branch December 9, 2022 03:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants