xdsclient: improve federation watchers test #5696
Conversation
easwars
force-pushed
the
federation_watchers_test
branch
from
f5cf418 to
2f2baf2
Compare
easwars
force-pushed
the
federation_watchers_test
branch
from
dda7d57 to
573eda7
Compare
|
|
||
| // Create a bootstrap file in a temporary directory. | ||
| // Create the bootstrap |
There was a problem hiding this comment.
"the bootstrap"? Are we a western? bootstrap file please. Or just delete this comment "bootstrapContents, err := xdsinternal.BootstrapContents" is self explanatory but I don't feel strongly about this.
| // a single resource with canonicalized context parameters. The test verifies | ||
| // that both watchers are notified. |
There was a problem hiding this comment.
So sorry, but what does "canonicalized context parameters mean"? Here and below.
There was a problem hiding this comment.
https://github.com/cncf/xds/blob/main/proposals/TP1-xds-transport-next.md#normalization is the spec. What canonicalized (or normalized) It isn't clear from reading that. But basically what it means for us is that we sort the context parameters. That is the reason why the following two resource names are considered the same:
xdstp:///envoy.config.listener.v3.Listener/xdsclient-test-lds-resource?a=1&b=2
xdstp:///envoy.config.listener.v3.Listener/xdsclient-test-lds-resource?b=2&a=1
Our federation spec does go into more detail here:
New-style resource names used as cache keys must be [normalized]
(https://github.com/cncf/xds/blob/main/proposals/TP1-xds-transport-next.md#normalization). In particular, this
means sorting the context params in normal lexicographic order.
If a new-style name has duplicate values for the same context param, the behavior is undefined. The easiest thing
is probably to just use the last value seen, since this allows the implementation to just populate the map by iterating
over the query params.
https://github.com/grpc/proposal/blob/master/A47-xds-federation.md
|
This has a conflict btw. |
easwars
force-pushed
the
federation_watchers_test
branch
from
d9076aa to
836c01e
Compare
easwars
force-pushed
the
federation_watchers_test
branch
from
157cbf6 to
925f214
Compare
Improve federation watchers test by moving to an e2e style test which verifies functionality without relying on any internal state.
This PR is similar to how the LDS watchers test was cleaned up in #5506.
#resource-agnostic-xdsclient-api
RELEASE NOTES: n/a