xdsclient: NACK endpoint resources with zero weight #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
force-pushed
the
eds_nack_zero_weight_endpoint
branch
from
ba1932c to
fa6b943
Compare
zasweq
approved these changes
Aug 3, 2022
| @@ -134,9 +138,13 @@ func parseEDSRespProto(m *v3endpointpb.ClusterLoadAssignment, logger *grpclog.Pr | |||
| return EndpointsUpdate{}, fmt.Errorf("duplicate locality %s with the same priority %v", lidStr, priority) | |||
| } | |||
| localitiesWithPriority[lidStr] = true | |||
| endpoints, err := parseEndpoints(locality.GetLbEndpoints()) | |||
| if err != nil { | |||
| return EndpointsUpdate{}, err | |||
There was a problem hiding this comment.
Please wrap this err with more information (see other errors in this function).
There was a problem hiding this comment.
parseEndpoints returns an error which has all the required information.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the existing behavior in other languages already (and Envoy), and we are late to the party.
Fixes: #5456
Summary of changes:
xdsclientto error out if it sees an endpoint resource with zero weightRELEASE NOTES: