cmd/protoc-gen-go-grpc: allow hooks to modify client structs and service handlers #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Mar 24, 2022
cmd/protoc-gen-go-grpc/grpc.go
Outdated
| @@ -36,9 +36,11 @@ const ( | |||
|
|
|||
| type serviceGenerateHelperInterface interface { | |||
| formatFullMethodName(service *protogen.Service, method *protogen.Method) string | |||
| generateNewClientConnInterface(g *protogen.GeneratedFile, clientName string) | |||
There was a problem hiding this comment.
Why "New"?
And it's generating a client struct, not the ClientConn interface, isn't it? So generateClientStruct?
menghanl
reviewed
Apr 4, 2022
cmd/protoc-gen-go-grpc/grpc.go
Outdated
| generateNewClientDefinitions(g *protogen.GeneratedFile, service *protogen.Service, clientName string) | ||
| generateUnimplementedServerType(gen *protogen.Plugin, file *protogen.File, g *protogen.GeneratedFile, service *protogen.Service) | ||
| generateServerFunctions(gen *protogen.Plugin, file *protogen.File, g *protogen.GeneratedFile, service *protogen.Service, serverType string, serviceDescVar string) | ||
| generateServerFunctions(gen *protogen.Plugin, file *protogen.File, g *protogen.GeneratedFile, service *protogen.Service, serverType string, serviceDescVar string) []string |
There was a problem hiding this comment.
How will the return value be used?
There was a problem hiding this comment.
Done. Removed.
menghanl
approved these changes
Apr 5, 2022
menghanl
reviewed
Apr 5, 2022
cmd/protoc-gen-go-grpc/grpc.go
Outdated
| handlerNames = append(handlerNames, hname) | ||
| } | ||
| genServiceDesc(file, g, serviceDescVar, serverType, service, handlerNames) | ||
| return handlerNames |
There was a problem hiding this comment.
Compiling error.
Delete this.
menghanl
approved these changes
Apr 5, 2022
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are supporting the service renaming by using a global variables which will cause issues in some scenarios.
This change allows us to modify the ClientConn interface and handlers, which allows us to store the renamed service name by each clientconn. This matches how the internal service renaming is implemented.
RELEASE NOTES: n/a