Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: set TCP_USER_TIMEOUT socket option for linux #5219

Merged
merged 1 commit into from
Mar 21, 2022
Merged

server: set TCP_USER_TIMEOUT socket option for linux #5219

merged 1 commit into from
Mar 21, 2022

Conversation

bonnefoa
Copy link
Contributor

@bonnefoa bonnefoa commented Mar 3, 2022 •
edited by dfawley
Loading

Implements proposal A18 (https://github.com/grpc/proposal/blob/master/A18-tcp-user-timeout.md).

Currently, TCP_USER_TIMEOUT can only be set on gRPC golang client.
The A18 proposal doesn't mention this should be restricted clients and the C-Core implementation does set TCP_USER_TIMEOUT on gRPC server (https://github.com/grpc/grpc/pull/16419/files#diff-b3242d6753e5e0f631f2aed3fc352e2f491696f5107ab2f1cc61d85b7926a192R169-R170)

So this PR adds the server part of #2307 and sets TCP_USER_TIMEOUT in the server transport.

RELEASE NOTES:

  • Support setting TCP_USER_TIMEOUT on grpc.Server connections using keepalive.ServerParameters.Time

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 3, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@zasweq zasweq requested a review from easwars March 9, 2022 19:06
@zasweq zasweq added this to the 1.46 Release milestone Mar 9, 2022
@easwars easwars added the Type: Feature New features or improvements in behavior label Mar 11, 2022
@easwars
Copy link
Contributor

easwars commented Mar 11, 2022

Thanks for the PR !!
Could you please rebase your git repo from master. We recently pushed a change which addresses the failing vet-proto GitHub Action.

@easwars
Copy link
Contributor

easwars commented Mar 11, 2022

@dfawley @menghanl
Could one of y'all please take a second look. Thanks.

@bonnefoa bonnefoa force-pushed the set_server_tcp_user_timeout branch from 64edfbd to 273e03d Compare March 14, 2022 07:31
@bonnefoa
Copy link
Contributor Author

Rebase done!

@dfawley dfawley merged commit 50d0d0a into grpc:master Mar 21, 2022
@orpheuslummis orpheuslummis mentioned this pull request May 16, 2022
Merged
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@easwars easwars easwars approved these changes

Assignees

@easwars easwars

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.46 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@bonnefoa @easwars @dfawley @zasweq