Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolver: replace AddressMap.Range with Keys #4891

Merged
merged 3 commits into from
Oct 20, 2021
Merged

resolver: replace AddressMap.Range with Keys #4891

merged 3 commits into from
Oct 20, 2021

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Oct 20, 2021

RELEASE NOTES: N/A

@dfawley dfawley added this to the 1.42 Release milestone Oct 20, 2021
@dfawley dfawley requested a review from menghanl October 20, 2021 20:09
menghanl
menghanl approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One comment in tests.

resolver/resolver.go Show resolved Hide resolved
resolver/map_test.go Outdated Show resolved Hide resolved
@menghanl menghanl assigned dfawley and unassigned menghanl Oct 20, 2021
@dfawley dfawley changed the title resolver: replace Range with Keys resolver: replace AddressMap.Range with Keys Oct 20, 2021
@dfawley dfawley merged commit f00baa6 into grpc:master Oct 20, 2021
@dfawley dfawley deleted the addrmaprange branch October 20, 2021 22:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@dfawley dfawley

Labels
Type: Bug
Projects
None yet
Milestone
1.42 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @menghanl