Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/protoc-gen-go-grpc: rework service registration #3828

Merged
merged 9 commits into from
Aug 25, 2020
Merged

cmd/protoc-gen-go-grpc: rework service registration #3828

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ea59137
protoc-gen-go-grpc: rework service registration
dfawley Aug 11, 2020
bce863c
add note about NewService behavior for missing methods in doc
dfawley Aug 19, 2020
91c6a17
review comments
dfawley Aug 19, 2020
4c1dc0f
go mod tidy
dfawley Aug 19, 2020
8575a2e
migration mode
dfawley Aug 20, 2020
b241705
convert internal/testing generated files
dfawley Aug 20, 2020
bb999ce
update README for migrationMode
dfawley Aug 21, 2020
82397c2
add _
dfawley Aug 21, 2020
2a04148
migrate remaining code
dfawley Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Documentation/server-reflection-tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ make the following changes:
@@ -61,6 +62,8 @@ func main() {
}
s := grpc.NewServer()
pb.RegisterGreeterServer(s, &server{})
pb.RegisterGreeterService(s, &pb.GreeterService{SayHello: sayHello})
+ // Register reflection service on gRPC server.
+ reflection.Register(s)
if err := s.Serve(lis); err != nil {
Expand Down
118 changes: 118 additions & 0 deletions balancer/grpclb/grpc_lb_v1/load_balancer.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

147 changes: 49 additions & 98 deletions balancer/grpclb/grpc_lb_v1/load_balancer_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading