xds: add temporary logging to LRS #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
Apr 1, 2020
xds/internal/balancer/lrs/lrs.go
Outdated
| Node: node, | ||
| }); err != nil { | ||
| } |
There was a problem hiding this comment.
Nit: Could this be in a single line.
| @@ -44,9 +44,11 @@ func (c *Client) ReportLoad(server string, clusterName string, loadStore lrs.Sto | |||
| cc *grpc.ClientConn | |||
| closeCC bool | |||
| ) | |||
| c.logger.Infof("Starting load report to server: %s", server) | |||
There was a problem hiding this comment.
This doesn't have "lrs" prefix?
There was a problem hiding this comment.
This is logging with the logger, from the xds_client. It's going to have prefix "xds-client".
This is where things are getting inconsistent. I will need to refactor LRS to support multiple clusters. The logs in this PR are temporary.
| if server == "" || server == c.opts.Config.BalancerName { | ||
| cc = c.cc | ||
| } else { | ||
| c.logger.Infof("LRS server is different from xDS server, starting a new ClientConn") |
There was a problem hiding this comment.
Same here? Is this expected?
xds/internal/balancer/lrs/lrs.go
Outdated
Comment on lines
373
to
375
| req := &lrspb.LoadStatsRequest{ | ||
| ClusterStats: ls.buildStats(clusterName), | ||
| }); err != nil { | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.