Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: fix typo in binarylog, "allowd" → "allowed" #3084

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

anthonyfok
Copy link
Contributor

Detected by Debian Lintian tool while packaging Hugo.

Many thanks!

@linux-foundation-easycla
Copy link

CLA Check
One or more committers are not authorized under a signed CLA as indicated below. Please click here to be authorized.

@easwars
Copy link
Contributor

easwars commented Oct 9, 2019

@anthonyfok
Could you please sign the CLA, so that we can go ahead and accept your PR. Thank you.

@easwars easwars added the Type: Internal Cleanup Refactors, etc label Oct 9, 2019
@easwars
Copy link
Contributor

easwars commented Oct 9, 2019

@jpalmerLinuxFoundation
I'm adding you here since you helped us on another PR where there was an issue with the CLA bot.

So on this PR, it was initially complaining that the contributor had not signed the CLA. But once I approved the PR (and sent a comment requesting them to sign the CLA), all the merge checks turned green. At this point, we don't know if the contributor has signed the CLA. Is it possible to get a notification on the PR itself, once the contributor signs it.

Thanks for your help.

@easwars easwars added this to the 1.25 Release milestone Oct 9, 2019
@jpalmerLinuxFoundation
Copy link

Hi @easwars, based on feedback from gRPC maintainers we removed the comment update for passing PRs. So after a user signs the CLA I'm expecting the checks to pass, but the comment will still show "CLA Not Signed" from the original failure.

I was able to confirm a signature for @anthonyfok. signature_id: 99cfb51d-1252-4224-afca-ca7dc573b9d2

@easwars
Copy link
Contributor

easwars commented Oct 9, 2019

Thanks a lot @jpalmerLinuxFoundation, for the quick update.

@easwars easwars merged commit 2d6a3ed into grpc:master Oct 9, 2019
@anthonyfok
Copy link
Contributor Author

Thank you so much @easwars and @jpalmerLinuxFoundation!
I wonder if the issue with the CLA bot has to do with multiple email addresses on my GitHub account, and with me using [email protected] for the git commit, and using [email protected], which was automatically filled in for me, for signing the CLA. I had the same doubt too when I saw that the button "CLA Not Signed" didn't get updated...

Oh, wait, @jpalmerLinuxFoundation actually answered my doubt already!

based on feedback from gRPC maintainers we removed the comment update for passing PRs

Sorry for not reading carefully enough before replying. Thanks again to you both for your help!

@dfawley
Copy link
Member

dfawley commented Oct 9, 2019

Thanks, @jpalmerLinuxFoundation, for looking into this so quickly!

I filed a feature request with easyCLA to investigate whether we can send comment updates after CLAs are signed (but still not send them if the CLAs are signed before the PR is submitted). The error signal in the comment update combined with the success signal in the current status, without any other comment updates, is pretty confusing IMO.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants