-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: fix typo in binarylog, "allowd" → "allowed" #3084
Conversation
|
@anthonyfok |
@jpalmerLinuxFoundation So on this PR, it was initially complaining that the contributor had not signed the CLA. But once I approved the PR (and sent a comment requesting them to sign the CLA), all the merge checks turned green. At this point, we don't know if the contributor has signed the CLA. Is it possible to get a notification on the PR itself, once the contributor signs it. Thanks for your help. |
Hi @easwars, based on feedback from gRPC maintainers we removed the comment update for passing PRs. So after a user signs the CLA I'm expecting the checks to pass, but the comment will still show "CLA Not Signed" from the original failure. I was able to confirm a signature for @anthonyfok. signature_id: 99cfb51d-1252-4224-afca-ca7dc573b9d2 |
Thanks a lot @jpalmerLinuxFoundation, for the quick update. |
Thank you so much @easwars and @jpalmerLinuxFoundation! Oh, wait, @jpalmerLinuxFoundation actually answered my doubt already!
Sorry for not reading carefully enough before replying. Thanks again to you both for your help! |
Thanks, @jpalmerLinuxFoundation, for looking into this so quickly! I filed a feature request with easyCLA to investigate whether we can send comment updates after CLAs are signed (but still not send them if the CLAs are signed before the PR is submitted). The error signal in the comment update combined with the success signal in the current status, without any other comment updates, is pretty confusing IMO. |
Detected by Debian Lintian tool while packaging Hugo.
Many thanks!