Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialOption: export WithContextDialer() #2629

Merged
merged 5 commits into from
Feb 25, 2019
Merged

dialOption: export WithContextDialer() #2629

merged 5 commits into from
Feb 25, 2019

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Feb 8, 2019

fixes #2627

dfawley
dfawley reviewed Feb 9, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we deprecate the timeout-based dialer, and expand on WithContextDialer's godoc text to match WithDialer's?

@menghanl menghanl self-assigned this Feb 15, 2019
@menghanl menghanl merged commit 40cb561 into grpc:master Feb 25, 2019
@menghanl menghanl deleted the context_dialer branch February 25, 2019 23:22
@menghanl menghanl added the Type: API Change Breaking API changes (experimental APIs only!) label Feb 25, 2019
@menghanl menghanl added this to the 1.19 Release milestone Feb 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@menghanl menghanl

Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Milestone
1.19 Release
Development

Successfully merging this pull request may close these issues.

Consider export withContextDialer and deprecate WithDialer
2 participants
@menghanl @dfawley