Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: add methods to allow setting grpc-trace-bin and grpc-tags-bin headers #1404

Merged
merged 4 commits into from
Aug 24, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jul 28, 2017

Also, pick these up in grpc's transport when sending and fill them in when receiving.

Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dfawley dfawley merged commit 69abda0 into grpc:master Aug 24, 2017
@menghanl menghanl added 1.6 Type: Feature New features or improvements in behavior labels Aug 24, 2017
@dfawley dfawley modified the milestone: 1.6 Release Aug 28, 2017
@dfawley dfawley deleted the stats branch August 29, 2017 20:14
menghanl pushed a commit to menghanl/grpc-go that referenced this pull request Aug 30, 2017
…headers (grpc#1404)

This is in preparation for preventing any user-supplied metadata starting with "grpc-", which is reserved.

* stats: add methods to allow setting grpc-trace-bin and grpc-tags-bin headers

Pick these up in grpc's transport when sending and fill them when receiving.

* Add tags/trace to metadata and tests for that behavior

This is temporary to maintain compatibility and provide a migration strategy.
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants